Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-1369] FE changes for registration types #176

Merged
merged 8 commits into from
Nov 6, 2024
Merged

[SDP-1369] FE changes for registration types #176

merged 8 commits into from
Nov 6, 2024

Conversation

marcelosalloum
Copy link
Collaborator

@marcelosalloum marcelosalloum commented Nov 5, 2024 •
edited
Loading

What

Initial FE changes for the new disbursement registration flow:

  • Remove everything that relies on country when parsing responses
  • Make disbursement.verification_type optional
  • In the “Wallets Provided” section, display a flag stating if the wallet is user_managed
  • Update the disbursement details screen with the verification_type and registration_contact_type fields

Screenshots

Screenshot 2024-11-05 at 10 52 50 AM Screenshot 2024-11-05 at 10 52 34 AM Screenshot 2024-11-05 at 2 39 45 PM

Why

Partially address https://stellarorg.atlassian.net/browse/SDP-1369

Pending

EDIT: being addressed in PR #177

  • When creating a disbursement, start with the registration type
  • Then Wallet provider. Which is disabled when the registration type ends with WALLET_ADDRESS
  • Then Asset. GET /assets should be fetched without the wallet_id when the registration type ends with WALLET_ADDRESS.
  • Then Verification type. Which is disabled when the registration type ends with WALLET_ADDRESS

@marcelosalloum marcelosalloum self-assigned this Nov 5, 2024
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

2 similar comments
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

@marcelosalloum marcelosalloum force-pushed the feat/SDP-1369-fe-changes-for-registration-types branch from 123f4e8 to 8e1a206 Compare November 5, 2024 22:30
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

quietbits
quietbits approved these changes Nov 6, 2024
View reviewed changes
src/helpers/formatWithTitleCase.ts Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

stellar-disbursement-platform-frontend-preview is available here:
http://sdp-frontend-pr176.previews.kube001.services.stellar-ops.com/

@marcelosalloum marcelosalloum merged commit 2f4a7e9 into develop Nov 6, 2024
7 checks passed
@marcelosalloum marcelosalloum deleted the feat/SDP-1369-fe-changes-for-registration-types branch November 6, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quietbits quietbits quietbits approved these changes

@marwen-abid marwen-abid Awaiting requested review from marwen-abid

Assignees

@marcelosalloum marcelosalloum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelosalloum @stellar-jenkins @quietbits