Revert "fix(ssr): fixes for scoped: true components during SSR (#6311)"

[christian-bromann]

What is the current behavior?

We are having issues updating Ionic framework due to a change introduced in #6311. The issue we see is in the Angular e2e test where the application just doesn't load:

ionic-team/ionic-framework#30524

cc @johnjenkins

What is the new behavior?

I am reverting the change and make a new release.

Documentation

Does this introduce a breaking change?

• Yes
• No

Testing

n/a

Other information

n/a

[johnjenkins]

@christian-bromann i’m pretty sure the PR you’re looking for is this one #6298

[johnjenkins]

this is the wrong PR for the flagged errors :)

[christian-bromann]

I have pushed a dev build @stencil/[email protected] to NPM to verify this on the Ionic side.

The last Nightly build failing: https://github.com/ionic-team/ionic-framework/actions/runs/16187432460
A Nightly build triggered by me using the dev build: https://github.com/ionic-team/ionic-framework/actions/runs/16199616480

[christian-bromann]

I created a reproduction case for you using the testbed from Ionic: https://drive.google.com/file/d/1wR9YqsPo93-iy8v67DFeTyykwcStJW53/view?usp=drive_link .. you can just download it and run it. Confusingly, if I run npm start and access the apps, everything works but when I run npm test , nothing loads. Maybe this is a Cypress qwirk?

Please let me know your thoughts and how we want to proceed here?

[johnjenkins]

@christian-bromann this is what I get locally -

the form / input related error occurs due to the one-time-password input just not being there for me ... I swapped to an IonInput just to get things building ... obvs those tests failed, but at least they ran. What am I missing here?

[johnjenkins]

following up - yeah, I don't appear to have ion-input-otp in my ionic core lib

idk if it's just a me thing

[christian-bromann]

@johnjenkins sorry, I don't know what happened to the reproduction case, I double checked and created a new zip file: https://drive.google.com/file/d/1r48gi1hqRABbJxWtPzPekmxpQcaLFAv2/view?usp=sharing

[christian-bromann]

Sorry, that one was also not correct, here is the final reproduction case: https://drive.google.com/file/d/1WC5bn27Ih5GGGJitrNzlxFbKW5qtuOE9/view?usp=sharing

Hold on, still working on a reproduction case

[christian-bromann]

Unfortunately I couldn't zip the reproduction case so here is the manual way:

> git clone [email protected]:ionic-team/ionic-framework.git
> cd ionic-framework

Update Stencil to latest:

-     "@stencil/core": "4.33.1",
+     "@stencil/core": "4.35.3",

in core/package.json, then run:

> npm i
> cd core && npm i && npm run build
> cd ../packages/angular && npm i && npm run sync && npm run build
> cd ../angular-server && npm i && npm run build
> cd ../angular/test
> ./build.sh ng19
> cd build/ng19/
> npm install && npm run sync

Now running the tests you will see that the tests using lazy components are failing:

npm test

---

Let's validate with the dev build:

> cd ../../../../../core && npm i && npm run build
> cd ../packages/angular && npm i && npm run sync && npm run build
> cd ../angular-server && npm i && npm run build
> cd ../angular/test
> ./build.sh ng19
> cd build/ng19/
> npm install && npm run sync

This should now pass:

npm test

[christian-bromann]

Closing in favor of #6343