Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Commit

Permalink
Prepare for CRAN submission
Browse files Browse the repository at this point in the history
  • Loading branch information
stephematician committed Jul 11, 2023
1 parent 815dc72 commit 2e8977c
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 14 deletions.
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ Bug-fixes
- Fix container overrun and incorrect (unweighted) sampling without
replacement.

Documentation fixes
- Incorrect spelling of Breiman and missing reference in README
- Added github links


# version 0.0.1

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ object and the separation of the (training) data from the forest, see `ranger`
[issue #304](https://github.com/imbs-hl/ranger/issues/304).

A multiple imputation algorithm using this package is under development: called
[`smirf`][smirf_github].
[`mimputest`][mimputest_github].

[mice_cran]: https://cran.r-project.org/package=mice
[miceranger_cran]: https://cran.r-project.org/package=miceRanger
[missranger_cran]: https://cran.r-project.org/package=missRanger
[ranger_cran]: https://cran.r-project.org/package=ranger
[smirf_github]: https://github.com/stephematician/smirf
[mimputest_github]: https://github.com/stephematician/mimputest


## Example
Expand Down
25 changes: 13 additions & 12 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
# literanger submission

This is a new release (fifth re-submission).
Submit version 0.0.2: bug fix and performance improvements.

- Removed Eigen dependency (eliminates header downloads).

Older changes compared to earlier submissions:

- Removed 'C++11' system requirement from previous submission.
- Updated case in title and replace T/F with TRUE/FALSE.
- Passes r-lib/actions/examples/check-standard.yaml
- Below are R CMD CHECK results from win-builder and my machine (Ubuntu 22.04).
- Passes r-lib/actions/examples/check-standard.yaml.
- Fixes container overflow identified in:
https://www.stats.ox.ac.uk/pub/bdr/memtests/clang-ASAN/literanger/00check.log


# `win-builder` R CMD CHECK results

```
❯ checking CRAN incoming feasibility ... [11s] NOTE
Maintainer: 'Stephen Wade <[email protected]>'
New submission
Package was archived on CRAN
Possibly misspelled words in DESCRIPTION:
Buuren (15:62)
Doove (20:17)
al (12:75, 20:26)
et (12:72, 20:23)
CRAN repository db overrides:
X-CRAN-Comment: Archived on 2023-07-10 as issues were not corrected
in time.
0 errors ✔ | 0 warnings ✔ | 1 note ✖
```
Expand All @@ -35,12 +35,13 @@ Older changes compared to earlier submissions:
# Ubuntu 22.04 (my machine) R CMD CHECK results

```
Duration: 48.3s
── R CMD check results ─────────────────────────────────── literanger 0.0.2 ────
Duration: 52.8s
❯ checking installed package size ... NOTE
installed size is 7.7Mb
sub-directories of 1Mb or more:
libs 7.5Mb
libs 7.6Mb
0 errors ✔ | 0 warnings ✔ | 1 note ✖
```
Expand Down

0 comments on commit 2e8977c

Please sign in to comment.