Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibSQL support to SQLite generator #357

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

mbezhanov
Copy link
Contributor

Closes #304.

Let me know if you require any adjustments or further details about the implementation.

Some of the more notable changes:

  1. Switched from index placeholders to regular placeholders during table filter processing to work around the following issue with the LibSQL driver:

    Arguments do not match SQL parameters: value for parameter $1 not found

  2. Adjusted ATTACH statements to make sure they use an unquoted DSN string to avoid the following LibSQL error:

    unable to execute attach database 'one' as one: SQL string could not be parsed: unsupported statement: attach database 'one' as one

  3. Added runtime modification of golden files for LibSQL tests (the idea is to reuse the original SQLite golden files, only tweaking the recorded DriverName, as they are otherwise identical).

@mbezhanov mbezhanov force-pushed the libsql-support branch 2 times, most recently from dbe4100 to 5115ce9 Compare February 13, 2025 11:02
@stephenafamo stephenafamo merged commit 7c0ffcb into stephenafamo:main Feb 23, 2025
8 checks passed
stephenafamo added a commit that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add libSQL support to SQLite generator
2 participants