meta_context and skip documentation #1853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Yaraslaut, when creating documentation for this new skip functionality, I realized that what we implemented only currently affects writing.
Skipping can also apply to reading. And, I think in some cases we want to only skip writing or only skip reading.
Here are the two approaches I'm thinking of taking.
First option is to simply name the function
skip_write
and askip_read
could be added later.The second option is to make the skip function templated on whether it is a read or write:
I'm leaning towards this second option. What are your thoughts?