Merge pull request #115 from stephenhky/develop

Python 2 to 3 upgrade on the use of `filter`
stephenhky · Dec 29, 2020 · 43bf568 · 43bf568
2 parents 7082cd0 + ef1f94d
commit 43bf568
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -86,6 +86,9 @@ If you would like to contribute, feel free to submit the pull requests. You can
 
 
 ## News
+
+* 12/28/2020: `shorttext` 1.4.5 released.
+* 12/24/2020: `shorttext` 1.4.4 released.
 * 11/10/2020: `shorttext` 1.4.3 released.
 * 10/18/2020: `shorttext` 1.4.2 released.
 * 09/23/2020: `shorttext` 1.4.1 released.

diff --git a/docs/conf.py b/docs/conf.py
@@ -58,7 +58,7 @@
 # The short X.Y version.
 version = u'1.4'
 # The full version, including alpha/beta/rc tags.
-release = u'1.4.4'
+release = u'1.4.5'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

diff --git a/docs/news.rst b/docs/news.rst
@@ -1,6 +1,7 @@
 News
 ====
 
+* 12/28/2020: `shorttext` 1.4.5 released.
 * 12/24/2020: `shorttext` 1.4.4 released.
 * 11/10/2020: `shorttext` 1.4.3 released.
 * 10/18/2020: `shorttext` 1.4.2 released.
@@ -64,6 +65,11 @@ News
 What's New
 ----------
 
+Release 1.4.5 (December 28, 2020)
+---------------------------------
+
+* Bugs fixed about Python 2 to 3 updates, `filter` in `shorttext.metrics.embedfuzzy`.
+
 Release 1.4.4 (December 24, 2020)
 ---------------------------------
 

diff --git a/setup.py b/setup.py
@@ -40,7 +40,7 @@ def test_requirements():
 
 
 setup(name='shorttext',
-      version='1.4.4',
+      version='1.4.5',
       description="Short Text Mining",
       long_description=package_description(),
       long_description_content_type='text/markdown',

diff --git a/shorttext/metrics/embedfuzzy/jaccard.py b/shorttext/metrics/embedfuzzy/jaccard.py
@@ -23,8 +23,8 @@ def jaccardscore_sents(sent1, sent2, wvmodel, sim_words=lambda vec1, vec2: 1-cos
     """
     tokens1 = tokenize(sent1)
     tokens2 = tokenize(sent2)
-    tokens1 = filter(lambda w: w in wvmodel, tokens1)
-    tokens2 = filter(lambda w: w in wvmodel, tokens2)
+    tokens1 = list(filter(lambda w: w in wvmodel, tokens1))
+    tokens2 = list(filter(lambda w: w in wvmodel, tokens2))
     allowable1 = [True] * len(tokens1)
     allowable2 = [True] * len(tokens2)