Generate endpoint info on About page based on provided HTTP host header #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing all the interface addresses we're listening on is not helpful on the About page. However, we serve the About page, we already know that we are reaching the server using the given hostname in the corresponding HTTP header, so let's use it to construct the URLs. This takes also into account that the request/access already passed proxy server(s), uses DNS CNAMEs etc. Signed-off-by: Michael Heimpold <[email protected]>
|
It is typical that charging stations are on a different network then the users browser (charging station on a M2M/VPN connection, browser on internet), thats why we show all interfaces |
|
correct, that's why we have https://github.com/RWTH-i5-IDSG/steve/wiki/Configuration#multiple-interfaces |
|
I fully understand your points. However, in my setup, SteVe is listening on localhost only and proxied by an Apache server - no M2M/VPN tunnel involved. In such a setup, only the localhost interface is listed in the About page which is more confusing than useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing all the interface addresses we're listening on is not helpful
on the About page. However, we serve the About page, we already know
that we are reaching the server using the given hostname in the
corresponding HTTP header, so let's use it to construct the URLs.
This takes also into account that the request/access already passed
proxy server(s), uses DNS CNAMEs etc.
Warning: Since I'm not a Java developer, I marked this PR as draft. I'm also unhappy
about some code duplications I introduce here. The primary goal is to show your
my understanding on how things should work in my eyes and to start a discussing about it.