Skip to content

Allow parsing only the block header when the txs are not required#52

Merged
stevenroose merged 1 commit intostevenroose:masterfrom
psgreco:parseblockheader
Jan 15, 2025
Merged

Allow parsing only the block header when the txs are not required#52
stevenroose merged 1 commit intostevenroose:masterfrom
psgreco:parseblockheader

Conversation

@psgreco
Copy link
Contributor

@psgreco psgreco commented Oct 5, 2024

Hal counterpart of ElementsProject/hal-elements#2

@stevenroose
Copy link
Owner

I just notice that this is a breaking change, because BlockInfo contains more info than BlockHeaderInfo, and this change makes it only show BlockHeaderInfo now even for blocks. I think you should first try to regularly parse as a full block and if that errors try if you can parse as a header.

@psgreco
Copy link
Contributor Author

psgreco commented Oct 7, 2024

You're right, pushed a new version that doesn't break compatibility

Copy link
Owner

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@stevenroose stevenroose merged commit be35f0d into stevenroose:master Jan 15, 2025
@psgreco psgreco deleted the parseblockheader branch January 16, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments