Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing only the block header when the txs are not required #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Oct 5, 2024

Hal counterpart of stevenroose/hal-elements#2

@stevenroose
Copy link
Owner

I just notice that this is a breaking change, because BlockInfo contains more info than BlockHeaderInfo, and this change makes it only show BlockHeaderInfo now even for blocks. I think you should first try to regularly parse as a full block and if that errors try if you can parse as a header.

@psgreco
Copy link
Contributor Author

psgreco commented Oct 7, 2024

You're right, pushed a new version that doesn't break compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants