-
Notifications
You must be signed in to change notification settings - Fork 12
add orb support... tricky #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be simplified. Depends if you think it's more or less readable.
Mostly for reference but just to note this may pin torch to 2.2.0, which at the moment is fine, but could be a problem in the future. (I need to double check but I think even uninstalled extras' dependencies are taken into account when installing) |
I think the installation is all working now with The README and getting started lists should also be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want a test for the calculator init e.g. parameters are set, and (invalid) model path works as expected, but generally looks good!
Rebased, and updated docs. Setting the Then the MacOS |
i wonder if we shall to a try catch... and then raise accordingly? |
01dea3c
to
480a391
Compare
It's possible there are slightly neater versions for setting the model, but I think it now uses the default model correctly, as well as using the pretrained model labels, or a loaded model (which is tested with their XS checkpoint file). Also installed cmake on our Mac, so hopefully those tests are fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't officially approve, but I think it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good to me
No description provided.