Add mesh CLI option and fix thermal mesh #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinelena
reviewed
Sep 6, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
alinelena
reviewed
Sep 12, 2024
oerc0122
reviewed
Sep 13, 2024
oerc0122
previously requested changes
Sep 13, 2024
Collaborator
oerc0122
left a comment
oerc0122
left a comment
There was a problem hiding this comment.
Once those floats are ints, I'm happy for this to go in.
alinelena
reviewed
Sep 13, 2024
oerc0122
reviewed
Sep 13, 2024
ElliottKasoar
force-pushed
the
add-mesh
branch
from
0f950d3 to
a20bd80
Compare
ElliottKasoar
force-pushed
the
add-mesh
branch
from
a20bd80 to
1266fe5
Compare
alinelena
approved these changes
Oct 2, 2024
Member
Author
|
(Draft until decided on approach in sync with #320) |
Member
|
I will not draft it.. but merge it and 320 rebased based on it. |
Member
Author
|
I agree 320 needs to be rebased, I mostly just want to be sure we want to change the type here. Feels silly to change the type, then immediately change it again, but yeah I think a tuple either just for a diagonal supercell, or a custom Union of tuples, is looking like the way to go, so this should be a sensible starting point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting point to resolves #305