enable hdf5 for phonons bands #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ElliottKasoar
left a comment
ElliottKasoar
left a comment
There was a problem hiding this comment.
Generally looks good, thanks!
We should add a test for the hdf5 bands, and it looks like there are a couple of LZMAErrors in the tests still.
oerc0122
previously approved these changes
Aug 12, 2025
alinelena
force-pushed
the
phonons-hdf5
branch
from
ab58e1f to
1ad865f
Compare
Co-authored-by: Elliott Kasoar <[email protected]>
Co-authored-by: Elliott Kasoar <[email protected]>
Co-authored-by: Elliott Kasoar <[email protected]>
Member
ElliottKasoar
left a comment
ElliottKasoar
left a comment
There was a problem hiding this comment.
Generally looks great, thanks!
Should we perhaps add a quick check that the new hdf5 can be loaded in at least one of the tests? All the places where we used to open the .xz file are now just yaml, so I don't think we test it anywhere.
alinelena
force-pushed
the
phonons-hdf5
branch
from
10c7e09 to
e83d80b
Compare
ElliottKasoar
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.