Add UMA #574
Merged
Add UMA #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
reviewed
Jul 24, 2025
oerc0122
previously approved these changes
Jul 24, 2025
Collaborator
oerc0122
left a comment
oerc0122
left a comment
There was a problem hiding this comment.
Looks reasonable. Optional simplification.
Co-authored-by: Jacob Wilkins <[email protected]>
This reverts commit 4c11594.
oerc0122
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #550. See also #572
Since fairchem v2 doesn't support most eqV2/eSEN models, I've added this as its own architecture/extra (
uma), which currently conflicts with most other models, unfortunately.Note: I originally tested the default model and the labelled model, but could not escape memory issues on the GitHub runners e.g. https://github.com/ElliottKasoar/janus-core/actions/runs/16473199093/job/46567628372, so this doesn't test the default model.