Improved test infrastructure #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initialize an app inside test_helper for rails 3 * gemfiles/ contains gemfiles for 2.3, 3.0, 3.1, and 3.2 * rake bundles:test runes tests against all gemfiles * rake bundles:install and bundles:update installs/updates
|
Wow, great patch to set the testing infrastructure right. One point, though: are you sure that we need to have those *.lock in the repository? |
Tests do not pass under rails 2.3 because of an issue related to respond_to_missing? and delegation. see https://rails.lighthouseapp.com/projects/8994/tickets/5410-multiple-database-queries-when-chaining-named-scopes-with-rails-238-and-ruby-192
|
You are right. I've removed *.gemfile.lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closely related to #142
I've made an attempt at improving the test setup.
These commits add gemfiles for rails 2.3, 3.0, 3.1, and 3.2. This is somewhat similar to how thoughbot/paperclip is tested. A rails application is initialized in test_helper.rb for rails versions >= 3 which should alleviate the need for a dummy project.
Added a few new rake tasks
Tests for one version can be run like
Also added a .travis.yml, result can be seen here
http://travis-ci.org/#!/jhawthorn/declarative_authorization/builds/1841883