Skip to content

Configurable InsertPosition #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinodonnell wants to merge 3 commits into from
Closed

Configurable InsertPosition #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ded92d
added a way to pass position to stimulus controller
martinodonnell Dec 12, 2023
38523e6
added table example
martinodonnell Dec 12, 2023
ce73c1f
close tr correctly
martinodonnell Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,86 @@ <h1 class="text-4xl tracking-tight font-extrabold text-gray-900 sm:text-5xl md:t
</button>
</form>
</section>

<section class="mt-16">
<form data-controller="nested-form" data-nested-form-position-value="beforeend">
<template data-nested-form-target="template">
<tr class="odd:bg-gray-100 nested-form-wrapper" data-new-record="true">
<td class="p-2">New todo</td>
<td class="p-2">
<input
id="NEW_RECORD"
name="user[todos_attributes][NEW_RECORD][description]"
class="appearance-none border w-full py-2 px-3 rounded-l-md text-gray-700 leading-tight focus:outline-none focus:shadow-outline"
placeholder="Your todo"
/>
</td>
<td class="p-2">
<button
class="cursor-pointer inline-flex items-center px-3 sm:text-sm"
type="button"
data-action="nested-form#remove"
title="Remove todo"
>
X
</button>
<input type="hidden" name="user[todos_attributes][NEW_RECORD][_destroy]" />
</td>
</tr>
</template>

<table class="table-auto border nested-form-wrapper">
<thead>
<tr>
<th class="p-2">Label</th>
<th class="p-2">Input</th>
<th class="p-2"></th>
</tr>
</thead>
<tbody id="nested-form-target" data-nested-form-target="target">
<tr class="odd:bg-gray-100 nested-form-wrapper" data-new-record="false">
<td class="p-2">Your todo</td>
<td class="p-2">
<input
id="todo-1"
name="user[todos_attributes][0][description]"
class="appearance-none border w-full py-2 px-3 rounded-l-md text-gray-700 leading-tight focus:outline-none focus:shadow-outline"
value="Pet the cat"
/>
</td>

<td class="p-2">
<button
class="cursor-pointer inline-flex items-center px-3 sm:text-sm"
type="button"
data-action="nested-form#remove"
title="Remove todo"
>
X
</button>
<input type="hidden" name="user[todos_attributes][0][_destroy]" />
</td>
</tr>
</tbody>
</table>

<button
id="nested-form-button"
type="button"
data-action="nested-form#add"
class="mt-4 bg-white hover:bg-gray-100 text-gray-800 font-semibold py-2 px-4 border rounded shadow"
>
Add todo
</button>

<button
type="submit"
class="mt-4 bg-indigo-600 hover:bg-indigo-400 text-white font-semibold py-2 px-4 border rounded shadow"
>
Save todos
</button>
</form>
</section>
</div>

<!-- This example requires Tailwind CSS v2.0+ -->
Expand Down
43 changes: 43 additions & 0 deletions spec/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,46 @@ describe('#nestedForm', (): void => {
expect(target.previousElementSibling.innerHTML).toContain('New todo')
})
})

describe('#nestedForm tables', (): void => {
beforeEach((): void => {
startStimulus()

document.body.innerHTML = `
<form data-controller="nested-form" data-nested-form-position-value="beforeend">
<template data-nested-form-target="template">
<tr class="nested-form-wrapper" data-new-record="true">
<td>New todo</td>
</div>
</template>

<table>
<thead>
<tr>
<th>Todo</th>
</tr>
</thead>
<tbody data-nested-form-target="target">
<tr>
<td>Your todo</td>
</tr>
</tbody>
</table>

<button type="button" data-action="nested-form#add">Add todo</button>
</form>
`
})

it('should add new todo to end of table body', (): void => {
const target: HTMLElement = document.querySelector("[data-nested-form-target='target']")
const addButton: HTMLButtonElement = document.querySelector("[data-action='nested-form#add']")

// @ts-ignore
expect(target.lastElementChild.innerHTML.trim()).toContain('<td>Your todo</td>')

addButton.click()

expect(target.lastElementChild.innerHTML).toContain('<td>New todo</td>')
})
})
7 changes: 6 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,25 @@ export default class extends Controller {
targetTarget: HTMLElement
templateTarget: HTMLElement
wrapperSelectorValue: string
positionValue: InsertPosition

static targets = ['target', 'template']
static values = {
wrapperSelector: {
type: String,
default: '.nested-form-wrapper'
},
position: {
type: String,
default: 'beforebegin'
}
}

add (e: Event) {
e.preventDefault()

const content: string = this.templateTarget.innerHTML.replace(/NEW_RECORD/g, new Date().getTime().toString())
this.targetTarget.insertAdjacentHTML('beforebegin', content)
this.targetTarget.insertAdjacentHTML(this.positionValue, content)
}

remove (e: Event): void {
Expand Down