Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle enableOfflineQueue correctly when disconnected #1354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle enableOfflineQueue correctly when disconnected #1354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export function throwIfInSubscriberMode(commandName, RedisMock) {

export function throwIfNotConnected(commandName, RedisMock) {
if (isNotConnected(RedisMock)) {
if (commandName !== 'connect' && commandName !== 'defineCommand') {
if (commandName !== 'connect' && commandName !== 'defineCommand' && !RedisMock.options.enableOfflineQueue) {
throw new Error(
"Stream isn't writeable and enableOfflineQueue options is false"
)
Expand Down
7 changes: 7 additions & 0 deletions test/integration/commands/connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,11 @@ describe('connect', () => {
redis.disconnect()
}
})

it('should not throw if executing any command when not connected and using enableOfflineQueue as true', async () => {
const redis = new Redis({ lazyConnect: true, enableOfflineQueue: true })

await expect(redis.get('key')).resolves.not.toThrow()
redis.disconnect()
})
})