Fix outstanding clippy warnings

[liamkinne]

• Fix feature names for chip variant stm32g4A1 -> stm32g4a1 and some typos of stm32g49a.
• Fix comment indentation in comments
• Fix missing type in mem::transmute use

[liamkinne]

@ryan-summers a PR for you to look at, please.

CI issues are unrelated. Will fix them in another PR.

[ryan-summers]

Pinging some of the original contributors for this HAL - The other asked about maintainership of this HAL on the Rust Embedded matrix channel. @usbalbin, @no111u3, and @dotcypress are any of you still maintaining this crate and are you available for review?

[usbalbin]

Does this build for the stm32g4a1 and stm32g491? I believe there were quite a lot of issues when I updated the CI to run for all devices so I excluded them. There is also #77 trying to atleast get them to compile, not sure if anything has changed since i worked on that.

BTW, I am happy to review but I do not have permissions to merge things

[liamkinne]

@usbalbin you are correct. I've rolled back the commit stating support for the stm32g4a1 in the readme. Otherwise this PR is just to fix the warnings thrown up by the CI.

[usbalbin]

LGTM

[usbalbin]

I will try posting a PR trying to fix the clippy warnings unless someone else does it first

[liamkinne]

@usbalbin I'm happy to do that next. Just wanted to get this one sorted out before I start spamming this repo with PRs.

[usbalbin]

Awesome :)

[adamgreig]

@usbalbin, would you be interested in helping maintain this crate (and so getting permission to review/merge)?

[usbalbin]

@usbalbin, would you be interested in helping maintain this crate (and so getting permission to review/merge)?

Yes, I would :)

Expect no miracles but I am happy to try to help.

[usbalbin]

@adamgreig is there anythig I need to do to get access(assuming you want me to)?

[usbalbin]

Thanks a lot! :)

[adamgreig]

@adamgreig is there anythig I need to do to get access(assuming you want me to)?

I've invited you to join the team, you should have got an email or maybe can see the invitation at https://github.com/stm32-rs/?

[usbalbin]

@adamgreig is there anythig I need to do to get access(assuming you want me to)?

I've invited you to join the team, you should have got an email or maybe can see the invitation at https://github.com/stm32-rs/?

Thank you :)

[usbalbin]

Any preferences for merge method?

[adamgreig]

I usually do a regular merge (no squash or rebase) but I'm not picky and it's not really for me to say here; perhaps stick to whatever has been done historically here unless you have strong feelings about doing it differently.