Fully Enforced Cordic #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
reviewed
Nov 8, 2024
| fn constrain(self, rcc: &mut Rcc) -> CordicReset; | ||
| } | ||
|
|
||
| impl Ext for CORDIC { | ||
| #[inline] | ||
| fn constrain(self, rcc: &mut Rcc) -> CordicReset { | ||
| rcc.rb.ahb1enr.modify(|_, w| w.cordicen().set_bit()); | ||
| rcc.rb.ahb1enr().modify(|_, w| w.cordicen().set_bit()); |
There was a problem hiding this comment.
Would you like to add the cordic feature to CI so this will be checked?
There was a problem hiding this comment.
Good point, I'm unfamiliar with your CI scheme, is my change correct?
There was a problem hiding this comment.
Haha, it appears it is correct :)
usbalbin
approved these changes
Nov 9, 2024
|
Is it ok if I merge this or do want to add anything more? |
|
This code has been stagnant for months, so I think it's safe to merge :) Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new
from_*register accessor methods, the fully type enforced Cordic implementation can be merged!