Demacrofy SPI #218
Merged
Demacrofy SPI #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
usbalbin
reviewed
Jul 17, 2025
usbalbin
reviewed
Jul 17, 2025
|
Looks nice from what I can tell :) Have you had the chance to test this? |
|
I tested the optimized driver back when I was doing the HAL 1.0 changes, moving out of the macro shouldn't have changed anything behavior-wise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had done some work on moving code out of the macros last year, but it kind of got stuck waiting for the hal-1 pr being merged, recently i saw that there was ongoing work on de-macroing other peripherals and though I'd try getting this upstreamed.
It also contains some SPI driver optimizations that make it do blocking mode fairly fast (1/4 to 1/2 of the CPU clock), though i haven't checked how they impact code size