-
-
Notifications
You must be signed in to change notification settings - Fork 102
Implement adding/removing timeouts #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amycatgirl
wants to merge
15
commits into
stoatchat:main
Choose a base branch
from
amycatgirl:feat/timeouts-again
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
Contributor
Author
|
fuck this was meant to be a draft, hold on |
Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
not sure how to signal the change to the input since the underlying html inputs are handled separately, i should probably make it a option within the component. Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
1b2edbc to
45b1116
Compare
whyyyyyyyy Signed-off-by: Amy <[email protected]>
Signed-off-by: Amy <[email protected]>
i swear this was implemented before, oh well. it's implemented now 👍 Signed-off-by: Amy <[email protected]>
Contributor
|
Marked as draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
Closes #287
Brief overview of the changes
timeoutprop to MessageBox and amemberprop to the message composerStill working out some kinks, but the modals/context menu entries work as expected.