fix: Report Content Message overflows with embeds. #538
+303
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to potential FloatingSelect Signed-off-by: pridgey <[email protected]>
pridgey
force-pushed
the
pridgey/report-content-message-overflow
branch
from
3b28db8 to
f461957
Compare
pridgey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus proposed fixes to potential FloatingSelect.
I noticed @insertish had some quick scribbles with the FloatingSelect and I like the concept. Fixed some things so it could target the mdui-meni-items in the shadow dom and successfully grab their values.
Happy to remove this, just figured this was a good conversation starter.
The main fix here is with Report Content. Messages with embeds overflow the 240px, so instead I've changed it to an 80vh and an overflowY of hidden.