Skip to content

Supports multiple tags by operations #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

EwenQuim
Copy link
Contributor

@EwenQuim EwenQuim commented Jul 25, 2024

Supporting multiple tags for one operation

Fixes #2262. We highly need it for Fuego 🙏🏼

@EwenQuim EwenQuim requested a review from a team as a code owner July 25, 2024 12:17
@EwenQuim EwenQuim requested a review from daniel-white July 25, 2024 12:17
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit ec4385a
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/66cd976dc32f53000895abf8
😎 Deploy Preview https://deploy-preview-2623--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit ec4385a
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/66cd976dc17f5e0008a7cede
😎 Deploy Preview https://deploy-preview-2623--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EwenQuim
Copy link
Contributor Author

I don't know why it fails on Angular but works for React, I didn't touch the framework part, only the core. Works locally too.

And I can't access CircleCI logs :/ This might be a one-time miss, can you re-run the tests please?

@EwenQuim
Copy link
Contributor Author

@lukasikp @darekplawecki is it possible to review if you have time, please?

@mnaumanali94 mnaumanali94 requested review from mnaumanali94 and removed request for daniel-white August 16, 2024 10:56
@mnaumanali94 mnaumanali94 added the t/to-review To be reviewed by the team label Aug 16, 2024
@mrydz
Copy link

mrydz commented Aug 23, 2024

Our team would also love for this feature to be merged.

@EwenQuim
Copy link
Contributor Author

This PR has very few lines and passes the tests.
It corrects an issue that have a few thumbs up and is very clear.

Is it possible to review it? It should be quick and unlock a lot of people!
@mnaumanali94 @lukasikp @darekplawecki

@ben-smartbear ben-smartbear merged commit d1421fd into stoplightio:main Aug 27, 2024
7 checks passed
@ben-smartbear
Copy link
Contributor

Merged! Thanks for the PR!

@weyert
Copy link
Contributor

weyert commented Aug 28, 2024

Thanks for merging. I will update my PR as it is probably conflicting now.

@EwenQuim
Copy link
Contributor Author

EwenQuim commented Sep 5, 2024

Which one are you talking about @weyert ?

@mrydz
Copy link

mrydz commented Sep 5, 2024

I'm guessing this one #2603

@EwenQuim
Copy link
Contributor Author

EwenQuim commented Sep 6, 2024

This is not the same feature :)

What this feature means is to support the fact that an operation can have multiple tags. It's not the same as x-tagGroup

@mrydz
Copy link

mrydz commented Sep 6, 2024

Right, different operations, but impacts the same code for display so they need to update their PR to account for the changes in this PR.

image

@EwenQuim
Copy link
Contributor Author

EwenQuim commented Sep 6, 2024

My bad I thought they wanted to close their PR, I'm just tired, sorry about that

AhalyaPai pushed a commit to jpmorganchase/elemental that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/to-review To be reviewed by the team triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Tags Of The Operation
6 participants