Skip to content

Conversation

@aharpervc
Copy link

@aharpervc aharpervc commented Sep 19, 2024

Elements Default PR Template

In general, make sure you have: (check the boxes to acknowledge you've followed this template)


Hi, I noticed that your section label says "Query Parameters". However, it seems more accurate to refer to this as "Query String Parameters". I realize the OpenAPI spec sometimes refers to the parameter object location as "query", so from that perspective, there is a thing called "query parameter". However, the audience for documentation shown in Elements is more broad than that, and so being more clear that these parameters should be placed in the query string seems useful.

It's the difference between picking a display label for folks who are very aware of OpenAPI-isms, vs picking a display label which works better for general web principles independent of OpenAPI.

@aharpervc aharpervc requested a review from a team as a code owner September 19, 2024 18:52
@aharpervc aharpervc requested a review from Asmodeios September 19, 2024 18:52
@netlify
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 758aaa5
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/6718a24ebc2ded0008ddd337
😎 Deploy Preview https://deploy-preview-2712--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 758aaa5
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/6718a24e9c391d00081df7b2
😎 Deploy Preview https://deploy-preview-2712--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants