Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http-negotiator): #2381 add additional warn log message #2550

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(http-negotiator): #2381 add additional warn log message #2550

merged 1 commit into from
Jul 2, 2024

Conversation

lukaszzazulak
Copy link
Contributor

Addresses #2381

Summary

Added warn log message for mismatched exampleKey.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@lukaszzazulak lukaszzazulak requested a review from a team as a code owner July 2, 2024 17:45
@lukaszzazulak lukaszzazulak requested review from daniel-white and removed request for a team July 2, 2024 17:45
brendarearden
brendarearden approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@brendarearden brendarearden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukaszzazulak lukaszzazulak merged commit 64a23fc into master Jul 2, 2024
7 checks passed
@lukaszzazulak lukaszzazulak deleted the feat/add-additional-warn-log-message-2381 branch July 2, 2024 17:58
This was referenced Jul 2, 2024
Merged
Merged
@stoplight-bot stoplight-bot mentioned this pull request Jul 19, 2024
Closed
This was referenced Aug 8, 2024
Merged
Merged
ilanashapiro pushed a commit to ilanashapiro/prism that referenced this pull request Aug 22, 2024
@lukaszzazulak @ilanashapiro
fix(http-negotiator): stoplightio#2381 add additional warn log message (
876388e 
stoplightio#2550)
@stoplight-bot stoplight-bot mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendarearden brendarearden brendarearden approved these changes

@daniel-white daniel-white Awaiting requested review from daniel-white daniel-white was automatically assigned from stoplightio/bear-claws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszzazulak @brendarearden