Skip to content

Conversation

@bitswamp
Copy link

@bitswamp bitswamp commented Nov 15, 2024

Summary

My team wants to integrate the Prism proxy into our CI pipeline, without having to modify all our existing e2e tests to print out the validation errors in case of failure.

This PR changes the behaviour of the --errors flag so that in addition to returning validation errors in the response body (the existing behaviour), the validation failures are also printed in the prism proxy output (similar to the current behaviour without the --errors flag).

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A (I'm open to adding a test, but the change didn't affect any existing tests)
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

Proxy output with --errors before change:

2024-11-15_13-59

Proxy output with --errors after change:

2024-11-15_13-58

@bitswamp bitswamp requested a review from a team as a code owner November 15, 2024 18:15
@mnaumanali94 mnaumanali94 self-requested a review January 10, 2025 13:56
@bitswamp bitswamp force-pushed the feature/validation-logging-with-errors-flag branch from 0fe7bc5 to a76811a Compare November 4, 2025 17:12
@bitswamp
Copy link
Author

bitswamp commented Nov 4, 2025

This PR previously couldn't be merged because the markdown-link-check job didn't run -- I don't know why. I amended my commit with a small markdown change and rebased it onto current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants