Skip to content

docs(repo): clarifying relationship to RFC 9535 #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

docs(repo): clarifying relationship to RFC 9535 #2777

wants to merge 4 commits into from
+1 −1

Conversation

dret
Copy link
Contributor

@dret dret commented Feb 4, 2025

Adresses #2773 .

@dret dret requested a review from a team as a code owner February 4, 2025 16:35
frankkilcommins
frankkilcommins requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@frankkilcommins frankkilcommins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go.

The spectral repo also follows conventional commits and similar type of linting for PRs. Thus you'll need to change the PR title (and perhaps commit messages) to pass the linting checks (e.g. docs(repo): clarifying relationship to RFC 9535)

@dret dret changed the title Clarifying relationship to RFC 9535 docs(repo): clarifying relationship to RFC 9535 Feb 13, 2025
@mnaumanali94
Copy link
Contributor

@dret Can you please take a stab at amending the commit message to follow conventional commits. That would fix the pipeline.

@YOU54F
Copy link

YOU54F commented Apr 11, 2025

Hey @dret

Friendly nudge for an update to the commit message to resolve the CI failure

@dret
Copy link
Contributor Author

dret commented Apr 15, 2025

Friendly nudge for an update to the commit message to resolve the CI failure

Done. Thanks for the nudge.

@dret
Copy link
Contributor Author

dret commented Apr 15, 2025

And even doner now. Seems like I managed to violate the style guide in multiple ways...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankkilcommins frankkilcommins frankkilcommins requested changes

@YOU54F YOU54F YOU54F approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dret @mnaumanali94 @YOU54F @frankkilcommins