Move removing dependencies to inside settings check#229
Merged
mnaumanali94 merged 1 commit intostoplightio:masterfrom Nov 25, 2024
Merged
Move removing dependencies to inside settings check#229mnaumanali94 merged 1 commit intostoplightio:masterfrom
mnaumanali94 merged 1 commit intostoplightio:masterfrom
Conversation
When changing dependent files, they are being removed as dependencies when the file is being closed. This is causing problem associated with them to remain until VS Code is closed.
mnaumanali94
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When changing dependent files, they are being removed as dependencies when the dependent file is being closed. This is causing the problem of them remaining even after the main file is closed. Moving the removal inside the check for
settings.validatefixes this issue.Fixes #205.
Checklist
Does this PR introduce a breaking change?