(mostly) iSCSI iBFT fixes #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this please. |
vojtechtrefny
approved these changes
Aug 3, 2023
| @@ -374,3 +374,56 @@ def test_login_noauth_badauth(self): | |||
| udisks = self.get_object('') | |||
| objects = udisks.GetManagedObjects(dbus_interface='org.freedesktop.DBus.ObjectManager') | |||
| self.assertNotIn(dbus_path, objects.keys()) | |||
|
|
|||
| def test_ibft(self): | |||
There was a problem hiding this comment.
I think we should tag this test as UNSAFE, just to be sure we won't try to login to some ibft iscsi when running in some random environment.
There was a problem hiding this comment.
Yeah, good idea. I don't expect these tests to be ever used except of very isolated cases of specific testing environments.
No D-Bus reply was sent when asking for loading a module while disabled by a commandline switch.
There's currently no way to distinguish between force-no-auth and use-fw-discovered-auth-info scenarios from the D-Bus API so let's assume that the caller wants to retain the firmware-discovered auth info unless overriden with specific CHAP credentials.
Module objects are responsible for claiming and tracking one or more devices (sysfs paths) that represent a given object purpose. For iSCSI sessions there may be multiple udev devices (LUNs) involved and needs to be tracked to realize when the session object is no longer needed.
Makes no sense to create a new phantom object whose uevent update would fail anyway.
In case the ACPI iBFT table is present in the system, do a simple test and try connecting to everything discovered.
Not every drive object is a valid target for the LSM plugin.
tbzatek
force-pushed
the
iscsi-ibft-fixes-1
branch
from
365bca5
to
1100034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple more other fixes that I found along the way.