-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration-test: Fix invalid escaping #1165
Conversation
Not sure what to replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to use raw strings (prefix the string with r'...'
) instead of escaping.
19d9f95
to
64cbad9
Compare
Something like this? |
64cbad9
to
5091113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you.
Looks like there are two more instances of this in the dbus tests:
|
Python 3.12 complains: integration-test:401: SyntaxWarning: invalid escape sequence '\$' subst_re = re.compile('\${([a-zA-Z_]+)}') integration-test:1047: SyntaxWarning: invalid escape sequence '\m' l = 'n"a\m\\"e' + fs_type integration-test:1053: SyntaxWarning: invalid escape sequence '\m' l = 'n"a\m\\"exft'
5091113
to
11dfecf
Compare
Good catch, fixed as well. |
Python 3.12 complains:
integration-test:401: SyntaxWarning: invalid escape sequence '$'
subst_re = re.compile('${([a-zA-Z_]+)}')
integration-test:1047: SyntaxWarning: invalid escape sequence '\m'
l = 'n"a\m\"e' + fs_type
integration-test:1053: SyntaxWarning: invalid escape sequence '\m'
l = 'n"a\m\"exft'