Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udiskslinuxdriveata: Prefer udev ID_ATA_* attributes #1312

Merged
merged 2 commits into from
Oct 1, 2024
Merged

udiskslinuxdriveata: Prefer udev ID_ATA_* attributes #1312

merged 2 commits into from
Oct 1, 2024

Commits on Sep 30, 2024

  1. udiskslinuxdriveata: Prefer udev ID_ATA_* attributes 

    Looking at the code in udisksata.c vs. udev/ata_id.c it appears
to have equal basis, only the udev part has evolved over time.
Except of one missing property it has feature parity, is better
maintained, runs earlier in the chain and is readily available.
There's no reason not to trust it as an authoritative source
of information.

The existing probing code needs to stay in UDisks for dm-multipath
device use, where udev ata_id is not run.

This needs ID_ATA_READ_LOOKAHEAD support in udev, merged in
systemd-257~devel. libudev version is checked during configure
and if lower, UDisks will fall back to the old probing approach
just for this missing property.

As the udev/ata_id probing code is generally more permissive,
it works on qemu-emulated AHCI+IDE devices as a bonus.
    @tbzatek
    tbzatek committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9390287 View commit details
    Browse the repository at this point in the history

  2. udiskslinuxdriveata: Trigger uevent after enabling/disabling SMART 

    Now that this is read from udev, it needs to be poked explicitly.
    @tbzatek
    tbzatek committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    464db39 View commit details
    Browse the repository at this point in the history