fix(solid, solid-vite): preset.js: module is not defined

[JellyBrick]

• ref fix: preset.js is esm (node 22.12.0) addon-webpack5-compiler-swc#11

[bichikim]

If executed on Node.js version 22.x.x, the same error occurs.

In the 20.x.x version, it runs without any errors.

[ShadowRZ]

@bichikim Curiously, this problem only appears when Node.js has its experimental support for require() ESM modules enabled, as when I run Storybook with NODE_OPTIONS="--no-experimental-require-module" the problem doesn't appear

[JellyBrick]

@bichikim Curiously, this problem only appears when Node.js has its experimental support for require() ESM modules enabled, as when I run Storybook with NODE_OPTIONS="--no-experimental-require-module" the problem doesn't appear

After v22.10.0 v22.12.0, require(esm) enabled by default.
see https://socket.dev/blog/node-js-delivers-first-lts-with-require-esm-enabled

[ShadowRZ]

After v22.10.0, require(esm) enabled by default.

Indeed, I'm also aware of this after I commented, BTW it's v22.12.0, not v22.10.0.

Hope the PR got merged and a new beta is released.

[JellyBrick]

@JonahPlusPlus Could you check this PR?

[JonahPlusPlus]

It seems fine (still gonna test it locally to verify the build output), but when comparing it to the Storybook repo, I noticed they are still using the require syntax. Does Storybook for React still work? Could I get a QRD of any PRs on that side?

(I want to make sure this project is consistent with practices on the main repo)

[JonahPlusPlus]

This also should change the .nvmrc version to 22.13.1.

[spuxx-dev]

CJS needs to die, fast. 😵 Can we expect a merge soon?

[JonahPlusPlus]

@spuxx-dev As much as I would like to get rid of CJS in this project, it's ultimately up to the Storybook devs to set the precedent for removing CJS.
The main Storybook repo still uses CJS, so I'm hesitant to merge any changes that drift from the norm (I'm just a contributor after all):
https://github.com/storybookjs/storybook/blob/74f9c669baf491d84572e7fc34656ecbb576ffe0/code/frameworks/react-vite/preset.js

[JonahPlusPlus]

Superseded by #20