-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Patch 8.5.4 #30459
base: latest-release
Are you sure you want to change the base?
Release: Patch 8.5.4 #30459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
yarnPath: ../.yarn/releases/yarn-4.3.0.cjs | ||
# Sometimes you get a "The remote archive doesn't match the expected checksum" error, uncommenting this line will fix it | ||
# checksumBehavior: 'update' | ||
yarnPath: .yarn/releases/yarn-4.6.0.cjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The yarnPath should be relative to the repository root, not the code directory. This should be ../.yarn/releases/yarn-4.6.0.cjs
instead of .yarn/releases/yarn-4.6.0.cjs
yarnPath: .yarn/releases/yarn-4.6.0.cjs | |
yarnPath: ../.yarn/releases/yarn-4.6.0.cjs |
async function run({ template }: RunOptions) { | ||
console.log(template.replace('/', '-')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Template parameter should be validated before use to avoid errors if undefined
async function run({ template }: RunOptions) { | |
console.log(template.replace('/', '-')); | |
async function run({ template }: RunOptions) { | |
if (!template) throw new Error('Template name is required'); | |
console.log(template.replace('/', '-')); |
156ae82
to
73009d4
Compare
…boxes-step Build: Update CircleCI configuration to remove build-sandboxes job (cherry picked from commit 0d7da86)
73009d4
to
e21d57d
Compare
This is an automated pull request that bumps the version from
8.5.3
to8.5.4
.Once this pull request is merged, it will trigger a new release of version
8.5.4
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x b2d8a3c06b7730abb903465c09045d05475caff3
If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.4