Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 8.5.4 #30459

Open
wants to merge 2 commits into
base: latest-release
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2025

This is an automated pull request that bumps the version from 8.5.3 to 8.5.4.
Once this pull request is merged, it will trigger a new release of version 8.5.4.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Addon A11y: Make Vitest Axe optional #30442
  • 🏗️ Build: Build: Update CircleCI configuration to remove build-sandboxes job #30360

🍒 Manual cherry picking needed!

The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.

  • #30442: git cherry-pick -m1 -x b2d8a3c06b7730abb903465c09045d05475caff3

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.5.4

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Feb 4, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

yarnPath: ../.yarn/releases/yarn-4.3.0.cjs
# Sometimes you get a "The remote archive doesn't match the expected checksum" error, uncommenting this line will fix it
# checksumBehavior: 'update'
yarnPath: .yarn/releases/yarn-4.6.0.cjs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The yarnPath should be relative to the repository root, not the code directory. This should be ../.yarn/releases/yarn-4.6.0.cjs instead of .yarn/releases/yarn-4.6.0.cjs

Suggested change
yarnPath: .yarn/releases/yarn-4.6.0.cjs
yarnPath: ../.yarn/releases/yarn-4.6.0.cjs

Comment on lines +11 to +12
async function run({ template }: RunOptions) {
console.log(template.replace('/', '-'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Template parameter should be validated before use to avoid errors if undefined

Suggested change
async function run({ template }: RunOptions) {
console.log(template.replace('/', '-'));
async function run({ template }: RunOptions) {
if (!template) throw new Error('Template name is required');
console.log(template.replace('/', '-'));

@storybook-bot storybook-bot force-pushed the version-patch-from-8.5.3 branch 2 times, most recently from 156ae82 to 73009d4 Compare February 4, 2025 14:08
valentinpalkovic and others added 2 commits February 4, 2025 14:58
…boxes-step

Build: Update CircleCI configuration to remove build-sandboxes job
(cherry picked from commit 0d7da86)
@storybook-bot storybook-bot force-pushed the version-patch-from-8.5.3 branch from 73009d4 to e21d57d Compare February 4, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants