-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
Web-components: Export html helper for custom render functions #30982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
View your CI Pipeline Execution ↗ for commit 9e878da.
☁️ Nx Cloud last updated this comment at |
The sample components still use This is "user" code instead of story code, so I didn't update it to use Storybook's |
6894cc0
to
9e878da
Compare
Closes #30979
What I did
html
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Create a WC sandbox and run it. Add a story with a custom render function.
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR re-exports the html function through @storybook/web-components to standardize custom render functions for web components.