Skip to content

Docs: Remove Webpack 5 frameworks #31043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

jonniebigodes
Copy link
Contributor

@jonniebigodes jonniebigodes commented Apr 2, 2025

Closes #30980

What I did

  • Removed the snippets and framework pages related to the issue
  • Adjusted the frontmatter order to match

What was not done:

  • The migration guide was not updated as it will be a part of a separate pull request

cc @kylegach and @valentinpalkovic

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR removes all documentation related to deprecated Webpack 5 frameworks for Vue and Web Components and updates sidebar order for Vite content.

  • Removed multiple snippets and framework docs (e.g., docs/_snippets/web-components-webpack5-add-framework.md, docs/_snippets/vue3-webpack5-add-framework.md).
  • Eliminated installation and transpilation guides for @storybook/web-components-webpack5 and @storybook/vue3-webpack5.
  • Adjusted ordering in docs/get-started/frameworks/vue3-vite.mdx and docs/get-started/frameworks/web-components-vite.mdx.
  • Updated install.mdx to remove references to the removed frameworks.

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Apr 2, 2025
@jonniebigodes jonniebigodes self-assigned this Apr 2, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Apr 2, 2025

View your CI Pipeline Execution ↗ for commit de28a55.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 19:49:14 UTC

@valentinpalkovic valentinpalkovic merged commit 8aca78d into next Apr 16, 2025
8 checks passed
@valentinpalkovic valentinpalkovic deleted the docs_removes_webpack_frameworks branch April 16, 2025 13:36
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Webpack 5 framework removal
2 participants