Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: create validator wrapper & set limits #34

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Oct 20, 2023

No tokens are set by the user. We put them into a queue, then set-power to accept them and get their delegation of power.

flow

  • on create, put in queue (has a query) to be Set-Power'ed by an admin
  • Set-Power should run the hooks if its new, event broadcast, etc for an actual create & amount of tokens. Remove from pending queue. It also sets the single delgation to the power desired
  • use cosmos stakingTypes & no conversion types?

other:

  • setting a single validator to be >30% of the chain VP errors (requires Unsafe: True / --unsafe cli flag to bypass (useful for 1-3 node networks)
  • you can not set less than 1 power for a node

@Reecepbcups Reecepbcups linked an issue Oct 20, 2023 that may be closed by this pull request
@Reecepbcups Reecepbcups linked an issue Oct 21, 2023 that may be closed by this pull request
@Reecepbcups Reecepbcups changed the title feat!: create validator wrapper feat!: create validator wrapper & set limitations Oct 21, 2023
@Reecepbcups Reecepbcups changed the title feat!: create validator wrapper & set limitations feat!: create validator wrapper & set limits Oct 21, 2023
@Reecepbcups Reecepbcups marked this pull request as ready for review October 23, 2023 17:28
@Reecepbcups
Copy link
Member Author

Definitely some cleanup work to do here, 2 new issues and 1 modified to account for it

@Reecepbcups Reecepbcups merged commit e54ff87 into main Oct 23, 2023
7 checks passed
@Reecepbcups Reecepbcups deleted the reece/create-val-wrap branch November 26, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe actions should not happen Creating new Validators @ runtime
1 participant