Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Domain Validation in 'check_dns_without_connection' Function #379

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Onyx2406
Copy link
Contributor

@Onyx2406 Onyx2406 commented Jul 1, 2023

Fixes Issue

#378

Changes proposed

Improved the domain validation in the check_dns_without_connection function by implementing a more secure domain checking mechanism.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@eldraco
Copy link
Collaborator

eldraco commented Jul 4, 2023

Thanks!! let us verify the code, test, and I think it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants