Open
Conversation
Collaborator
Author
|
Blocked by: #2086 |
Shourya742
force-pushed
the
2026-02-15-add-prop-test-to-framing
branch
2 times, most recently
from
0502115 to
a1523e4
Compare
Collaborator
Author
For now, I am not sure we should refactor the framing now or after the release. I have temporarily ignored the tests related to size_hint that were failing in order to unblock the PR. Once the relevant changes or refactors are introduced, we can revisit this and remove the ignore from those tests. Opening it for review. |
Shourya742
force-pushed
the
2026-02-15-add-prop-test-to-framing
branch
from
a1523e4 to
372d2a2
Compare
Shourya742
force-pushed
the
2026-02-15-add-prop-test-to-framing
branch
from
372d2a2 to
ba274db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #2068