Worker specific hashrate tracking extension (SOLUTION N. 1) #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @TheBlueMatt and @Fi3 about the possible DoS vectors introduced by PR #107 (specifically here), I decided to open a PR to implement SOLUTION N.1 outlined in this doc.
This PR adds an extension to directly send a
user_identity
field inside a newSubmitIdentifiedSharesExtended
. Theuser_identity
field is limited to a maximum of 32 bytes-length to not increase too much the additional bandwidth consumption for extended shares submissions.