-
-
Notifications
You must be signed in to change notification settings - Fork 137
[Draft] Enable psycopg v3 tests #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Co-authored-by: Thiago Bellini Ribeiro <[email protected]>
Co-authored-by: Thiago Bellini Ribeiro <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Reviewer's Guide by SourceryThis PR enables tests for psycopg v3, expands Django and Python version support, and migrates from django-mptt to django-tree-queries. Class diagram showing tree structure migrationclassDiagram
note for TreeNode "Replaces MPTT implementation"
class TreeNode {
+parent: TreeNode
+children: List[TreeNode]
+depth: int
+path: str
}
TreeNode --> TreeNode: parent
note for ArrayField "Now supports both psycopg2 and psycopg3"
class ArrayField {
+base_field
+size: Optional[int]
+default: Any
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 41 41
Lines 3778 3778
=======================================
Hits 3369 3369
Misses 409 409 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kwong Tung Nan <[email protected]>
@kwongtn now you can rebase this 😊 |
@kwongtn are you still going to work on this? |
Description
Merge the following first:
P.s. Not sure if putting like 50 test scenarios is a good idea though 😅
Also I was thinking -- are we even using postgres in tests? 🤔
Types of Changes
Checklist
Summary by Sourcery
Tests: