-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add directions for using dev containers #237
doc: Add directions for using dev containers #237
Conversation
Reviewer's Guide by SourceryThis pull request enhances the project's documentation by providing instructions for using Dev Containers. It guides users through installing the Dev Containers extension, opening the repository within a Dev Container, and completing the necessary environment setup. Additionally, it removes the now-redundant instructions for manually installing No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fruitymedley - I've reviewed your changes - here's some feedback:
Overall Comments:
- Thanks for adding this documentation, it will be helpful for new contributors.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! The explanation is really clear. I just added some comments about updating the old tutorial since it was never really what we used.
Also, I think we should mention this file in the Contribuiting section on README.md, so new contributors can find it more easily. What do you think?
I also added a reference to this doc in the README.md |
Co-authored-by: Luis Gustavo <[email protected]>
Nice! |
Add directions to documentation for using dev containers
Description
pre-commit
/setuptools
instructions as this is handled automatically by Dev ContainersTypes of Changes
Issues Fixed or Closed by This PR
192
Checklist
Summary by Sourcery
Update the contributing documentation to include instructions for using dev containers, including installing the extension, opening the repo, and environment setup. Remove the pre-commit and setuptools installation instructions as they are now handled automatically by dev containers.
Documentation: