Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensions support to federation.field #3239

Merged

Conversation

bricker
Copy link
Contributor

@bricker bricker commented Nov 18, 2023

Description

Adds an optional extensions parameter to strawberry.federation.field, with default value None. The key is passed through to strawberry.field, so the functionality is exactly as described here.

Example:

strawberry.federation.field(extensions=[InputMutationExtension()])

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

n/a

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Nov 18, 2023

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Adds an optional extensions parameter to strawberry.federation.field, with default value None. The key is passed through to strawberry.field, so the functionality is exactly as described here.

Example:

strawberry.federation.field(extensions=[InputMutationExtension()])

Here's the tweet text:

🆕 Release (next) is out! Thanks to Bryan Ricker for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #3239 (6f764d1) into main (edebcb3) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3239   +/-   ##
=======================================
  Coverage   96.59%   96.60%           
=======================================
  Files         481      482    +1     
  Lines       29928    29952   +24     
  Branches     3691     3694    +3     
=======================================
+ Hits        28910    28935   +25     
+ Misses        834      833    -1     
  Partials      184      184           

Copy link

codspeed-hq bot commented Nov 18, 2023

CodSpeed Performance Report

Merging #3239 will not alter performance

Comparing bricker:bcr/2311/federation-field-extensions (6f764d1) with main (edebcb3)

Summary

✅ 12 untouched benchmarks

@bricker
Copy link
Contributor Author

bricker commented Nov 19, 2023

Maintainers please advise on the CodSpeed failure, I don't believe I touched any code that would have impacted the failed test, but perhaps I'm missing something.

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! thank you so much 😊

tests/schema/extensions/test_input_mutation_federation.py Outdated Show resolved Hide resolved
@patrick91 patrick91 merged commit e56ae59 into strawberry-graphql:main Nov 19, 2023
58 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants