-
-
Notifications
You must be signed in to change notification settings - Fork 593
feat: drop support for Python 3.9 #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @bellini666, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Thanks for adding the Here's a preview of the changelog: This release drops support for Python 3.9, which reached its end-of-life (EOL) We strongly recommend upgrading to Python 3.10 or a newer version, as older Here's the tweet text:
|
Thanks for adding the Here's a preview of the changelog: This release drops support for Python 3.9, which reached its end-of-life (EOL) We strongly recommend upgrading to Python 3.10 or a newer version, as older Here's the tweet text:
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4018 +/- ##
==========================================
+ Coverage 94.29% 94.41% +0.12%
==========================================
Files 533 532 -1
Lines 34893 34773 -120
Branches 1846 1828 -18
==========================================
- Hits 32901 32831 -70
+ Misses 1687 1647 -40
+ Partials 305 295 -10 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #4018 will not alter performanceComparing Summary
|
85f7c3a
to
ce81bae
Compare
# Note: Python 3.10.0 added the `kw_only` param to dataclasses, it was | ||
# just missed from the `make_dataclass` function: | ||
# https://github.com/python/cpython/issues/89961 | ||
if sys.version_info >= (3, 10, 1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this check? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the comment, there's a small issue on 3.10 that got fixed on 3.10.1, so yes.
Like, nobody should be using 3.10.0
anymore, and should be at least on 3.10.1
. But, who knows 🤣
ce81bae
to
de843f8
Compare
de843f8
to
d2be958
Compare
Dropping support for Python 3.9, which has EOLed, and removing a lot of unneeded code that we had to workaround some of its limitations