Fix: retain query params in urlToRelativePath
#240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcintyrehh
changed the title
urlToRelativePath
littlespex
previously approved these changes
Jul 28, 2025
|
Don't forget to add yourself to the |
Signed-off-by: Henry <[email protected]>
Signed-off-by: Henry <[email protected]>
mcintyrehh
force-pushed
the
fix/retain-nor-query-params
branch
from
4b1f6c0 to
a82409b
Compare
Signed-off-by: Henry <[email protected]>
littlespex
approved these changes
Jul 29, 2025
littlespex
merged commit 37ace47
into
streaming-video-technology-alliance:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes:
urlToRelativePathutil to persist the destination url's query params and hash in the relative path that is returned.In the case of CMCD's
norkey it is important to persist the original url's query params, as these may contain signatures or other information required for the pre-fetching of the next segment.Requirements Checklist