Eng 1450 legacy mapping support #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JVM fails to start when running tests due to `--add-opens` option not being recognised - `NoClassDefFound` exceptions due to missing JUnit 4 dependency
Isolated our type mappings from Snowflake's (`SnowflakeColumnTypeMapper`). Should make future Snowflake upgrades a little easier to merge. For now, have had to mark a couple of constructors in dependent classes as `public`, not just `@VisibleForTesting` to support this.
We introduced Java's `HexFormat` as a workaround, but, that's Java 17 compatible onwards and Snowflake's Kafka Connector has and still is Java 8 compatible so `HexFormat` not supported. Wrote a replacement method, doubt it'll be as performant and still not clear if we need this workaround. Should be re-tested.
Should've been committed in previous commit.
| switch (schemaName) { | ||
| case Decimal.LOGICAL_NAME: | ||
| if (kafkaType == org.apache.kafka.connect.data.Schema.Type.BYTES) { | ||
| return DECIMAL_SQL_TYPE; |
There was a problem hiding this comment.
@JonathonO I can't see this map in your new class
wrehman-skap
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.