-
Notifications
You must be signed in to change notification settings - Fork 8
Add SQL parsing from env var #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL parsing from env var #89
Conversation
@tomncooper The code is throwing a generic exception like before, but SonarQube is complaining. Should I change it to an |
IllegalArgumentException would be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this didn't turn out to be too complicated.
Can you also update the docs to describe this as an option and how users can use it.
We will also need to add coverage for this to the streams-e2e tests.
flink-sql-runner/src/main/java/com/github/streamshub/flink/SqlRunner.java
Outdated
Show resolved
Hide resolved
flink-sql-runner/src/main/java/com/github/streamshub/flink/SqlRunner.java
Outdated
Show resolved
Hide resolved
|
Description
Resolves #84
Testing: streamshub/streams-e2e#151
Adds ability to parse SQL from environment variable (key is hard-coded) e.g. like this:
Type of Change
Testing
Packit test job with smoke subset of tests is triggered by default.
If you want to run full flink test profile please type a following comment