Add SQL parsing from env var#89
Merged
tomncooper merged 5 commits intostreamshub:mainfrom Jul 17, 2025
Merged
Conversation
Member
Author
|
@tomncooper The code is throwing a generic exception like before, but SonarQube is complaining. Should I change it to an |
Member
|
IllegalArgumentException would be better |
tomncooper
reviewed
Jul 17, 2025
Collaborator
There was a problem hiding this comment.
I'm glad this didn't turn out to be too complicated.
Can you also update the docs to describe this as an option and how users can use it.
We will also need to add coverage for this to the streams-e2e tests.
flink-sql-runner/src/main/java/com/github/streamshub/flink/SqlRunner.java
Outdated
Show resolved
Hide resolved
flink-sql-runner/src/main/java/com/github/streamshub/flink/SqlRunner.java
Outdated
Show resolved
Hide resolved
|
tomncooper
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Resolves #84
Testing: streamshub/streams-e2e#151
Adds ability to parse SQL from environment variable (key is hard-coded) e.g. like this:
Type of Change
Testing
Packit test job with smoke subset of tests is triggered by default.
If you want to run full flink test profile please type a following comment