Max Weight to Compose format

[GaeaKat]

Working on Max Weight form

[westnordost]

Wow, you are relentless! 👍

Max weight... that has some similarities with the max height form - with the unit select, the input inside that sign graphic (for some countries) and all. Would you mind reviewing #6285 to make sure the implementation of both is consistent? (It's draft, not sure if he wants feedback so far, didn't yet ask)

[GaeaKat]

Max weight... that has some similarities with the max height form - with the unit select, the input inside that sign graphic (for some countries) and all. Would you mind reviewing #

I will take a look and try to match more ! I must admit I already had somewhat of a skeleton here with a bit of a tree structure after looking at how they handled the one layer of signs

the form asks for a GeneralMaxWeightSign and that returns depending on sign type
MaxWeightSign - MaxWeightGeneralSign, MaxWeightFinnishSign, or MaxWeightUSSign depending on country
MaxTandemAxleLoadSign
MaxMassSign
MaxLoadSign

[GaeaKat]

And yeah, I must admit, I want Street complete on iOS, and the best way for that is to help! That and I love the idea behind the app so helping it even if it never gets on iOS is ALSO good!

[westnordost]

Well, TBH I only have had a cursory look at #6285, important basically is my feedback to @ltoenning about the structure so to not duplicate composable code for the different signs. I.e I don't know if he implemented it that way, yet:

If all those sign layouts have both an input field and a unit selector dropdown (but depending on the sign it may be in- or outside of the sign layout), that means that there should be one composable for (length) input and one composable for the unit selector, separate from each other. The e.g. MaxWeightGeneralSign composable then glues those components together

[GaeaKat]

That makes sense yeah. I will spend some time looking at #6285 and try and make sure I go along with it!