-
-
Notifications
You must be signed in to change notification settings - Fork 403
Add dirt surface support to smoothness quest #6312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ooh smoothness quest, my compose image list pr at #6294 does touch on theese files a bit also! |
|
media source and license should be recorded in https://github.com/streetcomplete/StreetComplete/blob/af4b08c72016fd0d694f00acdf1aa72439b5f8df/app/src/androidMain/res/authors.txt |
|
Ah thanks, forgot that one. :) |
- Add 'dirt' to supported surfaces list for road/path smoothness quest - Implement dirt-specific smoothness descriptions - Add synthetic surface images for good/intermediate/bad/very_bad/horrible/very_horrible levels for dirt
af4b08c to
8c92e43
Compare
|
Thank you! Those pictures though... oof. They look so un-real. Actually, if I remember correctly, we use the same pictures for all non-paved surfaces starting from a certain horrible-level. So, to include dirt, we actually only need photos of the "better" surfaces. Especially for dirt surfaces, it makes sense to make photos of typical situations, like you would find on forest paths etc. (e.g. roots). And I really much prefer real photos. Aren't you keen on mountain biking? It should be possible to find plenty of examples in a typical hiking/biking spot. |
Yeah I know, but the pictures were so "rocky" that I thought it would make more sense to generate them specifically for dirt as well.
Well, they look somewhat unrealistic, but I don't think it's "that" bad. I mean, compared what we got a year before... I think they work fine, until we get better ones captured by someone. But it's quite an annoying blocker at the moment, as we can't capture smoothness for most tracks and paths, as
Well, I tried to keep "forests" out of the equation here, to avoid my bias of living in Germany, as SC is an international project, but if that helps with believability, I can certainly generate more believable images without this constraint. But sadly I cannot supply images for "dirt" with a lot of variation in surface quality, as we got pretty well maintained paths and tracks here in my corner of Germany. Maybe if I'm on holiday somewhere else eventually. The difficulties here are more "persistent mud", rocky paths and extreme elevation changes. |
|
or maybe look at wikimedia commons somewhere, there should be some pictures of the run of the mill "querfeldein-trampfelpfad" |
I actually did that last year already for an hour or so... it's really hard to find pictured of really nasty paths, because people seem more inclined to picture beautiful things, I guess. In addition, How about we mix this up: We use pictured for path qualities we do have pictured from and use synthetic ones for the rest? This gives us at least the chance to ship it, and replacing pictures in the future is pretty simple. So I've looked through commons/osm wiki and found the following candidates:
|
|
I want to remind about existence of https://community.openstreetmap.org/t/how-to-map-key-smoothness/109860 where there are ongoing attempts to gather images for various surfaces |
|
@matkoniecz I've scrolled through it. Not much about Btw: I think your categorization may be a bit too high for that. A heavy-duty off road vehicles can easily pass that. I know that because that are not tractor tire marks. :) |
|
Do you remember where you found that very_bad one? Seems quite fitting. Can you post it in that thread? And yes, these images are eye - gougingly artificial |
The sources are all linked below each image.
I don't really mind that look, as long as it conveys what it needs to convey I don't have hard feelings about it. It's not like that it's pretending to be art. Anyway, how about the pictures I've posted? |
|
I agree with @matkoniecz on the AI pictures. The |
|
Anyway, I'd close this PR, but not without having added those nice pictures of bad to horrible dirt to the wiki gallery: https://wiki.openstreetmap.org/wiki/Key:smoothness/Gallery |











Fixes #5499