Added missing messaging semantic attributes on the consumer spans #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Patierno <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]>
scholzj
reviewed
Dec 19, 2023
| @@ -90,8 +91,11 @@ private SpanBuilder getSpanBuilder(RoutingContext routingContext, String operati | |||
|
|
|||
| @Override | |||
| public <K, V> void handleRecordSpan(ConsumerRecord<K, V> record) { | |||
| String operationName = record.topic() + " " + MessageOperation.RECEIVE; | |||
| String operationName = record.topic() + " " + MessageOperation.RECEIVE.name().toLowerCase(Locale.ROOT); | |||
There was a problem hiding this comment.
What is the motivation behind using Locale.ROOT? I do not think we use it in many other places.
There was a problem hiding this comment.
It's the way the official interceptor applies the lowecase, I was just applying the same.
scholzj
approved these changes
Dec 19, 2023
ppatierno
deleted the
add-messaging-semantic-attributes-to-consumer-span
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current bridge implementation uses the Kafka producer interceptor way for injecting span on producing (by using the OpenTelemetry implementation) but it doesn't the same on the consumer side (because producer and consumers span are not linked the right way, as the OTel community is working to fix for the future).
For this reason we generate the Kafka consumer span manually but right now we are missing some "messaging" related smantic attributes which are added by the OTel interceptor on producer automatically.
This PR fixes this problem.