-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the script to generate the configuration #963
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Paolo Patierno <[email protected]>
This PR comes together with strimzi/strimzi-kafka-operator#11032 |
Signed-off-by: Paolo Patierno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Should we merge it so that the other PR can use :latest
container images?
Or maybe ... have you considered having for some time both mechanisms for better backwards compatibility?
Yeah. I am addressing feedback on that PR first and back to this to merge.
Tbh I think it's much effort to take both mechanisms mostly from the operator perspective to configure in both way depending on the version. I don't think it's worth it. As commented on the other PR we can add a line in the "Major changes, deprecations and removals" section for the operator CHANGELOG to highlight the bridge version to be used. |
I meant only the Bridge here -> to be able to use new bridge with old operator. I thought it might be useful for the 0.45 patch releases But I guess you are right that it is quite a lot of effort for very little gain. So I'm completely fine to have this merged without it. |
This PR is part of the work for the operator issue strimzi/strimzi-kafka-operator#10959 and remove the script to prepare the bridge configuration when running on container because it's done by the operator by making a ConfigMap then mounted on the bridge pod.