Skip to content

Fix double-signing during push to Central #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

see-quick
Copy link
Member

Resolved double-signing issue during central repository deployment. Previously, our release script included both the verify and deploy Maven phases. Since deploy already contains verify, this caused the signing plugin to run twice, producing .asc.asc signature files and resulting in central publishing errors:

Deployment e84a539c-8a6c-4d5c-a43d-4f9aca21fb1f failed
pkg:maven/io.strimzi/[email protected]:
 - Invalid signature for file: strimzi-test-container-0.111.0-rc1.pom.asc.asc
 - Invalid signature for file: strimzi-test-container-0.111.0-rc1.jar.asc.asc
 - Invalid signature for file: strimzi-test-container-0.111.0-rc1-javadoc.jar.asc.asc
 - Invalid signature for file: strimzi-test-container-0.111.0-rc1-sources.jar.asc.asc

@see-quick see-quick added this to the 0.111.0 milestone Jun 11, 2025
@see-quick see-quick self-assigned this Jun 11, 2025
@see-quick see-quick requested a review from a team June 11, 2025 08:54
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename the script file as push_to_central.sh please? We are moving all the components towards that.

@see-quick see-quick merged commit 5bbb98b into strimzi:main Jun 12, 2025
7 checks passed
see-quick added a commit that referenced this pull request Jun 16, 2025
* Fix double-signing during push to Central

Signed-off-by: see-quick <[email protected]>

* rename push artifacts script

Signed-off-by: see-quick <[email protected]>

---------

Signed-off-by: see-quick <[email protected]>
see-quick added a commit that referenced this pull request Jun 16, 2025
* Fix double-signing during push to Central

Signed-off-by: see-quick <[email protected]>

* rename push artifacts script

Signed-off-by: see-quick <[email protected]>

---------

Signed-off-by: see-quick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants