Skip to content

Moves ReactiveStateViewModel from FC to shared module. #10718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+345 −251
Draft

Moves ReactiveStateViewModel from FC to shared module. #10718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bf4f12
Moves StateViewModel to ui-core.
carlosmuvi-stripe Apr 24, 2025
bd2401a
Style fixes.
carlosmuvi-stripe Apr 24, 2025
3bb6ce9
Style fixes.
carlosmuvi-stripe Apr 24, 2025
f2d29fc
Fixes tests.
carlosmuvi-stripe Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...roid/financialconnections/features/accountpicker/AccountPickerPreviewParameterProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import com.stripe.android.financialconnections.model.FinancialConnectionsAccount
import com.stripe.android.financialconnections.model.FinancialConnectionsInstitution
import com.stripe.android.financialconnections.model.Image
import com.stripe.android.financialconnections.model.PartnerAccount
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success

internal class AccountPickerPreviewParameterProvider :
PreviewParameterProvider<AccountPickerState> {
Expand Down
10 changes: 5 additions & 5 deletions ...ava/com/stripe/android/financialconnections/features/accountpicker/AccountPickerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ import com.stripe.android.financialconnections.features.common.NoSupportedPaymen
import com.stripe.android.financialconnections.features.common.UnclassifiedErrorContent
import com.stripe.android.financialconnections.model.FinancialConnectionsInstitution
import com.stripe.android.financialconnections.model.PartnerAccount
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.paneViewModel
import com.stripe.android.financialconnections.presentation.parentViewModel
import com.stripe.android.financialconnections.ui.FinancialConnectionsPreview
Expand All @@ -55,6 +50,11 @@ import com.stripe.android.financialconnections.ui.components.FinancialConnection
import com.stripe.android.financialconnections.ui.sdui.fromHtml
import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsTheme
import com.stripe.android.financialconnections.ui.theme.LazyLayout
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized
import com.stripe.android.uicore.utils.collectAsState

@Composable
Expand Down
6 changes: 3 additions & 3 deletions .../com/stripe/android/financialconnections/features/accountpicker/AccountPickerViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ import com.stripe.android.financialconnections.navigation.Destination.ManualEntr
import com.stripe.android.financialconnections.navigation.Destination.Reset
import com.stripe.android.financialconnections.navigation.destination
import com.stripe.android.financialconnections.navigation.topappbar.TopAppBarStateUpdate
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsViewModel
import com.stripe.android.financialconnections.repository.ConsumerSessionProvider
import com.stripe.android.financialconnections.ui.HandleClickableUrl
import com.stripe.android.financialconnections.utils.error
import com.stripe.android.financialconnections.utils.measureTimeMillis
import com.stripe.android.uicore.navigation.NavigationManager
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Uninitialized
import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
Expand Down
4 changes: 2 additions & 2 deletions ...ipe/android/financialconnections/features/accountupdate/AccountUpdateRequiredViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ import com.stripe.android.financialconnections.model.FinancialConnectionsSession
import com.stripe.android.financialconnections.navigation.Destination
import com.stripe.android.financialconnections.navigation.Destination.InstitutionPicker
import com.stripe.android.financialconnections.navigation.topappbar.TopAppBarStateUpdate
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsViewModel
import com.stripe.android.financialconnections.repository.AccountUpdateRequiredContentRepository
import com.stripe.android.financialconnections.repository.CoreAuthorizationPendingNetworkingRepairRepository
import com.stripe.android.uicore.navigation.NavigationManager
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Uninitialized
import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
Expand Down
10 changes: 5 additions & 5 deletions ...ava/com/stripe/android/financialconnections/features/attachpayment/AttachPaymentScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ import com.stripe.android.financialconnections.features.common.AccountNumberRetr
import com.stripe.android.financialconnections.features.common.FullScreenGenericLoading
import com.stripe.android.financialconnections.features.common.UnclassifiedErrorContent
import com.stripe.android.financialconnections.model.LinkAccountSessionPaymentAccount
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.paneViewModel
import com.stripe.android.financialconnections.presentation.parentViewModel
import com.stripe.android.financialconnections.ui.FinancialConnectionsPreview
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized
import com.stripe.android.uicore.utils.collectAsState

@Composable
Expand Down
4 changes: 2 additions & 2 deletions .../com/stripe/android/financialconnections/features/attachpayment/AttachPaymentViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ import com.stripe.android.financialconnections.navigation.Destination.ManualEntr
import com.stripe.android.financialconnections.navigation.Destination.Reset
import com.stripe.android.financialconnections.navigation.destination
import com.stripe.android.financialconnections.navigation.topappbar.TopAppBarStateUpdate
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsViewModel
import com.stripe.android.financialconnections.repository.SuccessContentRepository
import com.stripe.android.financialconnections.ui.TextResource.PluralId
import com.stripe.android.financialconnections.utils.error
import com.stripe.android.financialconnections.utils.measureTimeMillis
import com.stripe.android.uicore.navigation.NavigationManager
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Uninitialized
import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
Expand Down
10 changes: 5 additions & 5 deletions ...rc/main/java/com/stripe/android/financialconnections/features/common/SharedPartnerAuth.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ import com.stripe.android.financialconnections.features.partnerauth.SharedPartne
import com.stripe.android.financialconnections.features.partnerauth.SharedPartnerAuthState.ViewEffect
import com.stripe.android.financialconnections.model.Entry
import com.stripe.android.financialconnections.model.OauthPrepane
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsSheetNativeState
import com.stripe.android.financialconnections.presentation.WebAuthFlowState
import com.stripe.android.financialconnections.presentation.collectAsState
Expand All @@ -67,6 +62,11 @@ import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsThem
import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsTheme.typography
import com.stripe.android.financialconnections.ui.theme.LazyLayout
import com.stripe.android.uicore.image.StripeImage
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized

@Composable
internal fun SharedPartnerAuth(
Expand Down
2 changes: 1 addition & 1 deletion ...m/stripe/android/financialconnections/features/consent/ConsentPreviewParameterProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import com.stripe.android.financialconnections.model.Image
import com.stripe.android.financialconnections.model.LegalDetailsBody
import com.stripe.android.financialconnections.model.LegalDetailsNotice
import com.stripe.android.financialconnections.model.ServerLink
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.ui.theme.Theme
import com.stripe.android.uicore.presentation.Async.Success

internal class ConsentPreviewParameterProvider : PreviewParameterProvider<ConsentPreviewState> {

Expand Down
10 changes: 5 additions & 5 deletions ...s/src/main/java/com/stripe/android/financialconnections/features/consent/ConsentScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ import com.stripe.android.financialconnections.features.consent.ConsentState.Vie
import com.stripe.android.financialconnections.features.consent.ui.ConsentLogoHeader
import com.stripe.android.financialconnections.model.ConsentPane
import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.paneViewModel
import com.stripe.android.financialconnections.presentation.parentViewModel
import com.stripe.android.financialconnections.ui.FinancialConnectionsPreview
Expand All @@ -48,6 +43,11 @@ import com.stripe.android.financialconnections.ui.sdui.fromHtml
import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsTheme.colors
import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsTheme.typography
import com.stripe.android.financialconnections.ui.theme.LazyLayout
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized
import com.stripe.android.uicore.utils.collectAsState

@ExperimentalMaterialApi
Expand Down
2 changes: 1 addition & 1 deletion ...ns/src/main/java/com/stripe/android/financialconnections/features/consent/ConsentState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package com.stripe.android.financialconnections.features.consent

import com.stripe.android.financialconnections.model.ConsentPane
import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.uicore.presentation.Async

internal data class ConsentState(
val consent: Async<Payload> = Async.Uninitialized,
Expand Down
4 changes: 2 additions & 2 deletions ...a/com/stripe/android/financialconnections/features/error/ErrorPreviewParameterProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import com.stripe.android.core.exception.APIException
import com.stripe.android.financialconnections.exception.InstitutionPlannedDowntimeError
import com.stripe.android.financialconnections.exception.InstitutionUnplannedDowntimeError
import com.stripe.android.financialconnections.model.FinancialConnectionsInstitution
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success

internal class ErrorPreviewParameterProvider :
PreviewParameterProvider<ErrorState> {
Expand Down
10 changes: 5 additions & 5 deletions ...tions/src/main/java/com/stripe/android/financialconnections/features/error/ErrorScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ import com.stripe.android.financialconnections.features.common.InstitutionPlanne
import com.stripe.android.financialconnections.features.common.InstitutionUnknownErrorContent
import com.stripe.android.financialconnections.features.common.InstitutionUnplannedDowntimeErrorContent
import com.stripe.android.financialconnections.features.common.UnclassifiedErrorContent
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.paneViewModel
import com.stripe.android.financialconnections.presentation.parentViewModel
import com.stripe.android.financialconnections.ui.FinancialConnectionsPreview
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized
import com.stripe.android.uicore.utils.collectAsState

@Composable
Expand Down
4 changes: 2 additions & 2 deletions ...ns/src/main/java/com/stripe/android/financialconnections/features/error/ErrorViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ import com.stripe.android.financialconnections.domain.NativeAuthFlowCoordinator.
import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest.Pane
import com.stripe.android.financialconnections.navigation.Destination
import com.stripe.android.financialconnections.navigation.topappbar.TopAppBarStateUpdate
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsViewModel
import com.stripe.android.financialconnections.repository.FinancialConnectionsErrorRepository
import com.stripe.android.financialconnections.utils.error
import com.stripe.android.uicore.navigation.NavigationManager
import com.stripe.android.uicore.navigation.PopUpToBehavior
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Uninitialized
import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
Expand Down
4 changes: 2 additions & 2 deletions ...ions/src/main/java/com/stripe/android/financialconnections/features/exit/ExitViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ import com.stripe.android.financialconnections.features.common.getBusinessName
import com.stripe.android.financialconnections.model.FinancialConnectionsSessionManifest.Pane
import com.stripe.android.financialconnections.navigation.Destination
import com.stripe.android.financialconnections.navigation.topappbar.TopAppBarStateUpdate
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsViewModel
import com.stripe.android.financialconnections.ui.TextResource
import com.stripe.android.uicore.navigation.NavigationManager
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Uninitialized
import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
Expand Down
8 changes: 4 additions & 4 deletions ...ancialconnections/features/institutionpicker/InstitutionPickerPreviewParameterProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ package com.stripe.android.financialconnections.features.institutionpicker
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
import com.stripe.android.financialconnections.model.FinancialConnectionsInstitution
import com.stripe.android.financialconnections.model.InstitutionResponse
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized

internal class InstitutionPickerPreviewParameterProvider :
PreviewParameterProvider<InstitutionPickerPreviewParameterProvider.InstitutionPreviewState> {
Expand Down
10 changes: 5 additions & 5 deletions ...stripe/android/financialconnections/features/institutionpicker/InstitutionPickerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ import com.stripe.android.financialconnections.features.common.ShapedIcon
import com.stripe.android.financialconnections.features.institutionpicker.InstitutionPickerState.Payload
import com.stripe.android.financialconnections.model.FinancialConnectionsInstitution
import com.stripe.android.financialconnections.model.InstitutionResponse
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Fail
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Success
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.paneViewModel
import com.stripe.android.financialconnections.ui.FinancialConnectionsPreview
import com.stripe.android.financialconnections.ui.TextResource
Expand All @@ -80,6 +75,11 @@ import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsColo
import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsTheme.colors
import com.stripe.android.financialconnections.ui.theme.FinancialConnectionsTheme.typography
import com.stripe.android.financialconnections.ui.theme.LazyLayout
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Fail
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Success
import com.stripe.android.uicore.presentation.Async.Uninitialized
import com.stripe.android.uicore.utils.collectAsState
import kotlinx.coroutines.launch

Expand Down
6 changes: 3 additions & 3 deletions ...ipe/android/financialconnections/features/institutionpicker/InstitutionPickerViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ import com.stripe.android.financialconnections.navigation.Destination.PartnerAut
import com.stripe.android.financialconnections.navigation.Destination.PartnerAuthDrawer
import com.stripe.android.financialconnections.navigation.destination
import com.stripe.android.financialconnections.navigation.topappbar.TopAppBarStateUpdate
import com.stripe.android.financialconnections.presentation.Async
import com.stripe.android.financialconnections.presentation.Async.Loading
import com.stripe.android.financialconnections.presentation.Async.Uninitialized
import com.stripe.android.financialconnections.presentation.FinancialConnectionsViewModel
import com.stripe.android.financialconnections.utils.ConflatedJob
import com.stripe.android.financialconnections.utils.error
import com.stripe.android.financialconnections.utils.isCancellationError
import com.stripe.android.financialconnections.utils.measureTimeMillis
import com.stripe.android.uicore.navigation.NavigationManager
import com.stripe.android.uicore.navigation.PopUpToBehavior
import com.stripe.android.uicore.presentation.Async
import com.stripe.android.uicore.presentation.Async.Loading
import com.stripe.android.uicore.presentation.Async.Uninitialized
import dagger.assisted.Assisted
import dagger.assisted.AssistedFactory
import dagger.assisted.AssistedInject
Expand Down
Loading
Loading